SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.47k stars 254 forks source link

Table Row - representation for Navigation Type, known in UI5 #4538

Open nikolay-kolarov opened 2 years ago

nikolay-kolarov commented 2 years ago

Feature Request Description

Issue origin: #3581

  1. TableRow (ui5-table-row) the ability to show an icon at the end of the row (in your case "arrow-right" icon to represent the "Navigation" type, known in UI5), f.e: 127998058-b2eda461-58f4-4258-85c3-02d40177c886

Priority

A clear and concise description of the impact/urgency of the required feature.

Stakeholder Info

CRP - more info in #3581

kartikc13 commented 2 years ago

@nikolay-kolarov : Could you please provide the status of this feature request? We are approaching our development close soon and really require this feature for many of our apps.

nikolay-kolarov commented 2 years ago

Hi @kartikc13 ,

Thanks for getting in contact. Unfortunately we were not able to pick-up this task due to other urgent and high priority tasks. Could you please provide info on the exact deadlines, so that I can check what we can do and when?

Thanks, Nikolay

emanurag commented 2 years ago

Hi @nikolay-kolarov I work with @kartikc13 and we would need this feature latest by April 4th, 2022. Could you please let us know if this is possible by then? Thanks, Anurag

nikolay-kolarov commented 2 years ago

Hello @emanurag and @kartikc13,

After further checking this, we think that it can be achieved with the already available APIs of the ui5-table.

Here is one sample showcasing how you can define active rows and listen to the ui5-row-click event: https://codesandbox.io/s/ui5-webcomponents-forked-715nq6?file=/index.html

I will keep the item open, so that we can use it to check if there is something missing and to create samples.

Please have a look at the sample and provide feedback, if you miss something.

Thanks, Nikolay

github-actions[bot] commented 1 year ago

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!

github-actions[bot] commented 1 year ago

Hello, everyone! The issue has been inactive for 28 days, so I am closing the issue.

hristop commented 11 months ago

Hi @nikolay-kolarov

We are writing to inform you about an important development regarding our ui5-table component. After careful consideration and received feedback, we have decided to focus on re-implementing and improving the existing table component based on the gathered feature requests and requirements. Here are some details about this decision and how it may affect our ongoing development efforts.

The decision was made based on several factors, including scalability, performance, accessibility and the ability to meet future feature requirements. Our team has recognised the limitations of the current table component and after careful consideration, we concluded that it would be more effective to develop a new table component from scratch rather than invest more time in enhancing the current one.

While this decision allows us to provide a better user experience and meet evolving needs, I want to acknowledge that it may have some implications for the feature requests that have been made for the current ui5-table component. We understand that stakeholders have invested time and effort in suggesting improvements and new features. Rest assured that we value your input, and we will make every effort to take these feature requests into consideration during the development of the new ui5-table component.

However, it is important to note that the new table component may introduce backward incompatible changes. These changes may impact the way the current table component functions, including its API and visual representation. We understand that this may require adjustments and adaptations on your end. Our team will strive to provide documentation and guidance to facilitate a smooth transition to the new table component.

We are excited about the opportunities this transition will bring and the positive impact it will have on our product.

Should you have any questions or concerns regarding this transition or its implications, please don't hesitate to reach out.

Thank you for your understanding and continued support as we embark on this important transition. Unfortunately for now we are not able to provide concrete timelines but we are currently working on a first preview version of the new WebComponent which should already offer a first impression of the concepts behind. We have gathered the feature requests and we surely have them in mind while developing the new component.

Best Regards, Hristo

mrCherry97 commented 5 months ago

Hi, we also are struggling with this topic, and it's very important for us. Best regards Mateusz Developer in Kyma team

ilhan007 commented 4 months ago

Hello @mrCherry97

I think this could be pretty much achieved with an additional column, where you can put the icon as shown here:

https://stackblitz.com/edit/js-7pzf5r?file=index.html

Screenshot 2024-02-14 at 17 56 23

Note: don't look at the blue vertical line, it's coming from another property, I just set it to see how they would look in combination.

mrCherry97 commented 4 months ago

Hi @ilhan007

Yes, it's possible to make it that way, but when you are using popin arrow needs to be in the middle of the row, but it is on top of the row: image

My requirements from UX: image

Example from UI5 Demo Kit: image

So your solution is working partially, but it's still a workaround, which is not making 100% of the requirements. Thanks for an idea!

Best regards Mateusz

ilhan007 commented 4 months ago

I think, it should be centered according to the main row (before the popin) not to the entire row after the popin.

Spec:

Screenshot 2024-02-15 at 10 47 56
ilhan007 commented 4 months ago
Screenshot 2024-02-15 at 10 49 53
mrCherry97 commented 4 months ago

Hi, I talked with our UX team, and they decided to go with your specs, and we will make an arrow in the middle of the main row. Thanks for all of the support!

ilhan007 commented 4 months ago

Welcome, get back to us in case you have issues with the arrow placement!

simlin commented 2 weeks ago

Hi,

In the 2.0 version of the UI5 Web Components we introduced a new Table component: https://sap.github.io/ui5-webcomponents/nightly/components/Table/

The table is still in an experimental phase and certain APIs might slightly change. Nevertheless we ask you to try out the new component already now. The earlier we get some feedback the better :)

The functionality you requested is currently in development and will be available in the new table soon.

Best Regards Jens