SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

ui5-link color issues #5267

Closed ee92 closed 2 years ago

ee92 commented 2 years ago

Bug Description

ui5-link does not respect the color from inline styles the change was introduced here: https://github.com/SAP/ui5-webcomponents/commit/ee44117ea11e6c0eec36ac9079fc90aa6356143d#diff-33a57c65c7633f6a842a56a7f7372857fcfd1c8144f0e1c295193b2735d809d8R60-R66

* another change introduced is that the link color is no longer the same for all states, and now has a different color for visited links

Expected Behavior

Expect the ui5-link to respect color from inline styles.

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Link/
  2. Add attribute to ui5-link style="color: green"
  3. Notice the link color is still blue

Context

Priority

Stakeholder Info (if applicable)

terezamch commented 2 years ago

Hello @ee92 ,

I don't really see any difference in the visited link vs. not visited. Otherwise, I will forward the issue about the inline style to the responsible team.

Best regards, Tereza

terezamch commented 2 years ago

Hello @SAP/ui5-webcomponents-topic-b,

When inline style like style="color: green" is added to the ui5-link tag, it does not get applied. To reproduce, open the playground and add style="color: green" to one of the links.

Please, have a look.

Best regards, Tereza

ee92 commented 2 years ago

@terezamch Thanks for looking into it!

There is a difference however, which can be reproduced on the demo page:

Screen Shot 2022-05-25 at 4 58 25 PM

Screen Shot 2022-05-25 at 4 59 08 PM

css rule: Screen Shot 2022-05-25 at 5 00 27 PM

It's not a huge deal, but does affect a lot of links, and with no way to change the color it is a blocker for us.