Select all checked even when there is no data. [Table] - Githubissues

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.

https://sap.github.io/ui5-webcomponents/

Apache License 2.0

1.51k stars 263 forks source link

Select all checked even when there is no data. [Table] #5294

Closed szabadkai closed 2 years ago

szabadkai commented 2 years ago

Bug Description

In the table, when there isn't data to show. in multiselect mode the select all checkbox is ticked by default.

Expected Behavior

For empty table checkbox should be unchecked or disabled

Steps to Reproduce

Context

UI5 Web Components version: 1.3.2
OS/Platform: MacOS
Browser: chrome
Affected component: Table

Priority

[ ] Low
[x] Medium
[ ] High
[ ] Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

Breaks entire application or system - High or Very High
Accessibility issue - Medium or High
Functional issue - Medium or High
Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

Organization: GoTo
Business impact: looks weird

terezamch commented 2 years ago

Hello @SAP/ui5-webcomponents-topic-rl,

When a Table is in MultiSelect mode and there is no data, the "select all" checkbox can be checked. I am not sure what is the correct behaviour - should it be disabled, should the user be unable to check it or something else, but the currect behaviour seem wrong.

It can be reproduced in the playground when the table from "Table with No Data" example has mode="MultiSelect" or in the following codesandbox.

Best regards, Tereza