search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 260 forks source link

ui5-shellbar: use header semantic element #5348

Closed JarrettChan closed 1 year ago

JarrettChan commented 2 years ago

Bug Description

Using <div role="banner"> instead of <header> semantic element. <header> is supported by modern browsers. https://www.w3.org/TR/using-aria/#rule1

Expected Behavior

Use <header> instead of <div role="banner">

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/ShellBar/
  2. shadow root contains <div role="banner">

Context

Priority

Stakeholder Info (if applicable)

niyap commented 2 years ago

Hello @SAP/ui5-webcomponents-topic-p,

Could you please check the proposed enhancement and analyse whether it is appropriate?

Thank you in advance!

Kind Regards, Niya

nikolay-kolarov commented 2 years ago

Hello,

This is an enhancement request, but in the end there will be no difference for the mapping on the accessibility tree, as <header> equals to <dir role="banner">. Therefore, there is no need to treat this with urgency, as it will not cause accessibility issue.

Best Regards, Nikolay

dobrinyonkov commented 2 years ago

Internal reference: 5778

JarrettChan commented 1 year ago

https://github.com/SAP/ui5-webcomponents/pull/6146