search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 263 forks source link

UploadCollection: better to include ReactNode type in noDataDescription and noDataText property and add Icon property #5354

Open tqq123 opened 2 years ago

tqq123 commented 2 years ago

Describe the bug better to include ReactNode type in noDataDescription and noDataText property of UploadCollection

Expected behavior support ReactNode type, it just support String type now, we can't even change the style of them, and it is better to add icon property to customize Icon when uploadlist is empty.

UI5 Web Components for React Information @ui5/webcomponents version: 1.3.1 @ui5/webcomponents-react version: 0.23.1 Operating System: MacOS 12.3.1 Browser: Chrome 102.0.5005.61

MarcusNotheis commented 2 years ago

Thanks for reaching out! This component and its API is developed in the UI5 Web Components Repo, so I'll forward this issue. As far as I know, these two props only accept strings as of now, so we can't just change our typings.

niyap commented 2 years ago

Hello @SAP/ui5-webcomponents-topic-rd,

That is a feature request to make "noDataDescription" and "noDataText" properties slots which can accept nodes. Could you please analyse whether it is appropriate?

Kind Regards, Niya

tqq123 commented 2 years ago

Hello Niya

thanks for your reply. for example, in this case, we want to customize the icon and text, we want the noDataDescription render in two lines and change the icon.but the component can not do this yet. so we hope that we can customize them.

Kind Regards, Casillas 

------------------ 原始邮件 ------------------ 发件人: "SAP/ui5-webcomponents" @.>; 发送时间: 2022年6月10日(星期五) 晚上6:34 @.>; 抄送: "~守候@@.**@.>; 主题: Re: [SAP/ui5-webcomponents] UploadCollection: better to include ReactNode type in noDataDescription and noDataText property and add Icon property (Issue #5354)

Hello @SAP/ui5-webcomponents-topic-rd,

That is a feature request to make "noDataDescription" and "noDataText" properties slots which can accept nodes. Could you please analyse whether it is appropriate?

Kind Regards, Niya

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>