search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.47k stars 254 forks source link

Accessibility issue combobox #5445

Closed Bilal3120 closed 1 year ago

Bilal3120 commented 2 years ago

Describe the bug Options not read out correctly when focussing.

Isolated Example CodeSandbox

To Reproduce Steps to reproduce the behavior:

  1. Go to CodeSandbox
  2. Open list of options in the combo box
  3. Cycle through the options using UP and DOWN keys.

Expected behavior Options should be read out like Entry 1 Text 1, Entry 2 Text 2..

Screenshots MicrosoftTeams-image (6)

UI5 Web Components for React Information @ui5/webcomponents 1.4.0: @ui5/webcomponents-react 0.25.6: Operating System: Mac OS Browser: Chrome

MarcusNotheis commented 2 years ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

nnaydenow commented 2 years ago

Hello @SAP/ui5-webcomponents-topic-rl,

Could you please check the issue? Items text is not announced with JAWS 2022.

Regards, Nayden

elenastoyanovaa commented 1 year ago

Accessibility expert analysis:

The issue is reproducible in the playground samples as well.

Currently we use the invisible messaging to announce the selected item. We call the announceSelectedItem in the combobox. For some reason (I think that this lead to double announcement) we do not include the item text nor the subtext in the announcement, which is incorrect. IMO we should include them as well, but we should test carefully before submitting anything. Some related PR:

https://github.com/SAP/ui5-webcomponents/pull/3358/files https://github.com/SAP/ui5-webcomponents/pull/5478/files

niyap commented 1 year ago

Hello @Bilal3120,

The issue about not announcing the additional text of an item is fixed with the following change: https://github.com/SAP/ui5-webcomponents/pull/5943 On the other hand, the issue about not always announcing the value of the combobox is a known screen reader issue and we do not have influence over it. Here is an isolated example with native HTML elements where the issue is also reproducible: https://jsbin.com/buzakereye/edit?html,output.

Kind Regards, Niya

DikshaHub commented 3 days ago

Hi @niyap,

You mentioned that the issue with not announcing the additional text of an item was fixed in #5943. Could you please let me know which version this change was released in?

Thank you!

nnaydenow commented 3 days ago

Hi @DikshaHub,

The fix is part of version 1.9.0 (https://github.com/SAP/ui5-webcomponents/releases/tag/v1.9.0)

DikshaHub commented 3 days ago

Thanks @nnaydenow