search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.54k stars 265 forks source link

Table: Multi select Responsiveness not working according to fiori guidelines #5555

Closed biancamattosn closed 2 years ago

biancamattosn commented 2 years ago

Describe the bug Multi select Responsiveness not working according to fiori guidelines.

Isolated Example Check storybook provided the same issue is hapenning there. https://sap.github.io/ui5-webcomponents-react/?path=/docs/data-display-table--default-story

To Reproduce Steps to reproduce the behavior:

  1. Go to table
  2. Reduce size of screen

Expected behavior The margin is not aligned and it is selecting only the first part of the row, and not the entire row

Screenshots Here is the react web components behavior: image

Here is the sample provided from the ui5 https://sapui5.hana.ondemand.com/#/entity/sap.m.Table/sample/sap.m.sample.TableMultiSelectMode image

UI5 Web Components for React Information @ui5/webcomponents version: 1.5.0 @ui5/webcomponents-react version: 0.26.0 Operating System: macOS Browser: Chrome

Lukas742 commented 2 years ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

dimovpetar commented 2 years ago

Hello @SAP/ui5-webcomponents-topic-rl ,

This issue is also reproducible on the UI5 Web Components Playground https://sap.github.io/ui5-webcomponents/playground/components/Table/. Looks like the selection background is applied only of the first tr element. For comparison check the sample in OpenUI5.

Best regards, Petar

niyap commented 2 years ago

Hello @biancamattosn,

Thanks for sharing your findings!

Actually that is a limitation, which is described in our documentation: https://sap.github.io/ui5-webcomponents/playground/components/Table/ "Note: Currently, when a column is shown as a pop-in, the visual indication for selection is not presented over it."

Kind Regards, Niya