[SF][ui5-table]: there is no bottom border of last data row for horizon theme

[GongRichard]

Bug Description

There is no bottom border of the last data row for horizon theme.

Expected Behavior

Should have bottom border of the last data row.

Steps to Reproduce

1. Go to 'https://sap.github.io/ui5-webcomponents/playground/components/Table/?sap-ui-theme=sap_horizon&isrtl=false'
2. There is no bottom border of last data row

Context

• UI5 Web Components version: {1.4.0}
• OS/Platform: {...}
• Browser: {}
• Affected component: {...}

Log Output / Stack Trace / Screenshots

Priority

• [ ] Low
• [x] Medium
• [ ] High
• [ ] Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

• Breaks entire application or system - High or Very High
• Accessibility issue - Medium or High
• Functional issue - Medium or High
• Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

• Organization: {...}
• Business impact: {...}

[stbodurov]

Hi @SAP/ui5-webcomponents-topic-rl,

Looks like the last table row does not have a bottom border in Horizon.

The last row of sap.m.Table doesn't have one either: https://sapui5.hana.ondemand.com/?sap-theme=sap_horizon#/entity/sap.m.Table/sample/sap.m.sample.TableBreadcrumb

Here are the styles that explicitly remove it in UI5: https://github.com/SAP/openui5/blob/36ec485601d65419a0cf983ec190b8a78f11a605/src/themelib_sap_horizon/src/sap/m/themes/sap_horizon/Table.less#L37

I could not find a requirement to remove the last row's border in the ResponsiveTable spec, but the "Table Borders" section states this for the Inner row type:

"Inner – This can be used to remove bottom border of the last item when Table or List do not have a footer and is wrapped in a container."

To me this seems to be intended. Could you take a look?

Regards, Stanislav

[elenastoyanovaa]

Hello @GongRichard ,

The current visual specification does not say that a bottom border should be present. The UI5 Table also does not have a bottom border in Horizon. I have informed the responsive designer, but a decision of the matter will be made after a discussion between the designers and the UI5 table team.

Can you please give us information why a bottom border should be present?

Kind Regards, Elena

[GongRichard]

Hi @elenastoyanovaa, You can check https://wiki.one.int.sap/wiki/display/visualcore/ResponsiveTable+%28Horizon%29+-+Specification, there has a bottom border. Thanks, Richard

[github-actions[bot]]

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!