search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

ui5-dialog NVDA is reading the header text as clickable when it is not #5618

Closed bonniegso closed 2 years ago

bonniegso commented 2 years ago

Bug Description

When navigating in browse mode with the screen reader, NVDA, the header text is read as "clickable heading level 2" when the header text is not clickable.

Expected Behavior

The screen reader should only read "heading NVDA should announce"heading level 2 " when user navigates to the header text in screen reader browse modes.

Steps to Reproduce

  1. Go to https://stackblitz.com/edit/js-34awxd
  2. Turn on NVDA screen reader
  3. Navigate to the "Open Dialog" button using your keyboard and select it
  4. Using your arrow keys navigate through the content on the dialog
  5. Observe that "clickable heading level 2 This is a header" is read

Isolated Example

https://stackblitz.com/edit/js-34awxd

Context

Priority

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

MapTo0 commented 2 years ago

Dear Colleagues,

I have corrected the example: https://stackblitz.com/edit/js-w8ckdd?file=index.js,index.html

The issue is reproducible only with NVDA, not with JAWS. I did not find any problem with the coding and this is probably a NVDA limitation.

Could you please with your ACC expert that the markup is correct and close this?

Regards, Martin

bonniegso commented 2 years ago

Hi @MapTo0,

It is only reproducible on NVDA, however, I think this issue might be fixable. NVDA reads "clickable" if there is a click handler on the element. Can you please verify that there is no click hander for the dialog header?

Thanks, Bonnie

MapTo0 commented 2 years ago

@bonniegso

In my opinion, it would be super strange if click handlers (javascript) affect the behaviour of a tool that reads just the markup (html). I believe this should not be the case here.

Regards!

TeodorTaushanov commented 2 years ago

Hi,

Please check the answer here: https://github.com/SAP/ui5-webcomponents/issues/5601#issuecomment-1223939324

Best, Teo