SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

[SF][ui5-icon]: icon always used accessibleName as tooltip #5690

Closed GongRichard closed 1 year ago

GongRichard commented 2 years ago

Bug Description

icon always used accessibleName as tooltip instead of using title property Please fix it in 1.7.0

Expected Behavior

Should use the value defined in title property as tooltip.

Steps to Reproduce

  1. Go to 'https://github.wdf.sap.corp/pages/xweb/team-goal/app/?templateId=1&mock#/detail?id=2'
  2. check the navigation icon in assignees table
  3. the tooltip shows the value from accessibleName

Context

Log Output / Stack Trace / Screenshots

image

Priority

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

unazko commented 2 years ago

Hello @SAP/ui5-webcomponents-topic-b,

The issue is with an icon only ui5-button component. In this case the ui5-button uses its internal icon tooltip. When we try to override ui5-button's title property and provide a custom tooltip it still uses its icon tooltip.

For example: < ui5-button icon="download" title="custom tooltip" >< /ui5-button >

We'll still get "download" tooltip instead of "custom tooltip".

Best Regards, Boyan

unazko commented 1 year ago

Hello @GongRichard,

Currently we are working on the following component enhancement https://github.com/SAP/ui5-webcomponents/issues/5733 We are expecting to complete it in two weeks from now and this would resolve the described issue.

Best Regards, Boyan

ilhan007 commented 1 year ago

Hello @GongRichard the issue been fixed and available since 1.12 with https://github.com/SAP/ui5-webcomponents/pull/6719