search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.54k stars 265 forks source link

Breadcrumbs: A11y Issue - The role of current page text should be 'text' #5717

Closed sleric1024 closed 9 months ago

sleric1024 commented 2 years ago

Describe the bug When reading "current page" (Notebooks) its announced as a "link" while its not a link but just plain text

Isolated Example https://codesandbox.io/s/competent-smoke-mqee3x?file=/src/App.js

To Reproduce Steps to reproduce the behavior:

  1. Go to https://mqee3x.csb.app/
  2. Inspect with Chrome developer tool
  3. Check the text Notebooks
  4. The role is marked as 'link' but it's just a plain text

Expected behavior The role should be text

Screenshots image

UI5 Web Components for React Information @ui5/webcomponents version: 1.6.0 @ui5/webcomponents-react version: 0.27.0 Operating System: MacOS Browser: Chrome

Additional context I am from SAP Successfactors, and this issue is reported from SF a11y expert.

Lukas742 commented 2 years ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

PetyaMarkovaBogdanova commented 2 years ago

Hi colleagues from @SAP/ui5-webcomponents-topic-p , can you, please, check if the current location element intentionally has the role of a link? Thank you!

Best regards, Petya Markova. (UI5 WC Dispatcher)

nnaydenow commented 2 years ago

Hi @sleric1024 ,

ui5-breadcrumbs is navigation with set of links. By W3C best practices last link should be marked as link even if it is only text. The best practices are analysed by our accessibility experts and seems that the component is implemented by their spec.

@dobrinyonkov

Regards, Nayden

anuvenkatesh1 commented 2 years ago

@nnaydenow Please see W3C example of breadcrumbs. https://www.w3.org/WAI/ARIA/apg/example-index/breadcrumb/index.html image Their "current page" is a "link" which has a "href" that seems to link back to same page. However your implementation has role of link with no href thus contradicting the role provided while it appears and functions as plain text.

dobrinyonkov commented 2 years ago

Specification update in progress. It involves work from our IXD team. An item is created on their board and work is planned to start with the next development takt.

nikolay-kolarov commented 2 years ago

I am setting this one to blocked until we have the UX design

dobrinyonkov commented 1 year ago

Specification update is done. Item is moved to our plannig queue to be implemented in the coming sprints. Progress will be shared in this issue.

dobrinyonkov commented 9 months ago

Internal Reference: FIORIDESIGN-7374, BGSOFUIPIRIN-6419

dobrinyonkov commented 9 months ago

Closed by https://github.com/SAP/ui5-webcomponents/pull/8206