Button: Color contrast issues in Horizon theme

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.

https://sap.github.io/ui5-webcomponents/

Apache License 2.0

1.56k stars 267 forks source link

Button: Color contrast issues in Horizon theme #5735

Closed sleric1024 closed 2 years ago

sleric1024 commented 2 years ago

Describe the bug Some component such as Button in Horizon theme do not meet minimum of 4.5:1 CC in default and focused states.

Button Component

Outline in focused case

Isolated Example Input https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-input--with-suggestion-item

Expected behavior Icons and visual focus outline are expected to meet minimum of 4.5:1 CC in default and focused states. It may also occurs in other component as well.

Additional context Dear colleague, I am from SAP Successfactors, currently we are fixing a11y issue for b2211 release, and the issues we reported by central a11y team.

Lukas742 commented 2 years ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

PetyaMarkovaBogdanova commented 2 years ago

Hi @sleric1024 , thank you for your contribution! Since Button and Input controls are maintained by different teams, can I, please, ask you to leave this issue context to remain for the Button only, and open a new one for the Input as well? Thank you!

Best regards, Petya Markova. (UI5 WC Dispatcher)

sleric1024 commented 2 years ago

@PetyaMarkovaBogdanova ， OK， thanks

ndeshev commented 2 years ago

Hello,

By specifications we support 4.5:1 contrast ratio for icons and text and 3:1 for other graphical objects and visual details, such as the focus outline. However, we could not apply this specifications for custom icons, specified by application.