SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

[SF_ACC] ShellBarItems support aria attributes in shadowroot button #5786

Closed lormanlau closed 1 year ago

lormanlau commented 2 years ago

Feature Request Description

A clear and concise description of what feature is missing. Is your feature request related to a problem? Please describe.

There is currently not a safe way of setting aria attributes into the shellbar items inner shadowroot button as the DOM can shift when adding a new shellbar item. Please help add a way to add aria attributes to the shadowroot button in shellbar items for accessibility. Current we would like aria-haspopup="menu".

Proposed Solution

A clear and concise description of the solution you would like to have. Add a buttonAriaAttributes property for us a pass a object to populate the aria attributes

Proposed Alternatives

A clear and concise description of any alternative solutions or features you've considered. Add property aria-haspopup to write the button element.

Additional Context

Add other context or screenshots related to the feature request here.

Priority

A clear and concise description of the impact/urgency of the required feature.

Stakeholder Info (if applicable)

LidiyaGeorgieva commented 2 years ago

Hello @SAP/ui5-webcomponents-topic-p, take a look of this feature request.

nikolay-kolarov commented 2 years ago

Hi @dobrinyonkov,

Please wait with the execution here, until we have a clear guidance on the aria-haspopup usage from acc.

Best Regards, Nikolay

dobrinyonkov commented 2 years ago

Internal Reference: BGSOFUIPIRIN-5943