search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

SF_ACC - ui5-shellbar: Buttons outline on focus is not having color contrast ratio 4.5:1 #5795

Closed pankajpandey01 closed 2 years ago

pankajpandey01 commented 2 years ago

Bug Description

ui5-shellbar- Buttons outline on focus is not having color contrast ratio 4.5:1

Expected Behavior

color contrast ratio should be at least 4.5:1

Steps to Reproduce

  1. Go to 'https://sap.github.io/ui5-webcomponents/playground/components/ShellBar/' (Theme: Quartz Light)
  2. Navigate to buttons like 'Notification', Search ... with keyboard
  3. Check color contrast ratio of button's focus outline

Context

Priority

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

LidiyaGeorgieva commented 2 years ago

Hello @SAP/ui5-webcomponents-topic-p please take over. The color of the focus is not correct.

pankajpandey01 commented 2 years ago

Hello, Please try to complete by Sep.15 and downport it to 1.6.x , if possible, as this is higher urgency for SFSF. Thank you.