SF_ACC_RatingIndicator: Cannot display in Safari browser

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.

https://sap.github.io/ui5-webcomponents/

Apache License 2.0

1.56k stars 267 forks source link

SF_ACC_RatingIndicator: Cannot display in Safari browser #5842

Closed sleric1024 closed 2 years ago

sleric1024 commented 2 years ago

Describe the bug The RatingIndicator cannot be displayed in Safari browser

Isolated Example https://w8ug3o.csb.app/

To Reproduce Steps to reproduce the behavior:

Go to https://w8ug3o.csb.app/ with Safari browser
The RatingIndicator is invisible

Expected behavior RatingIndicator should display correctly

Screenshots

UI5 Web Components for React Information @ui5/webcomponents version: 1.7.1 @ui5/webcomponents-react version: 0.28.1 Operating System: MaxOS Browser: Safari

Additional context I am from Successfactors, this issue can block b2211 release currently.

Lukas742 commented 2 years ago

Hi @sleric1024,

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

Hi colleagues,

you can also see the same in the playground, none of the indicators are displayed there for Safari neither.

PetyaMarkovaBogdanova commented 2 years ago

Hi colleagues from @SAP/ui5-webcomponents-topic-rl , I can reproduce the issue in Safari with https://sap.github.io/ui5-webcomponents/playground/components/RatingIndicator/ - the star icons in ui5-ratingIndicator are not present. I am not sure about the root cause, but when I remove display:flex style of the indicator's ui5-icon they are shown.

Best regards, Petya Markova. (UI5 Dispatcher)