SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 262 forks source link

ui5-shellbar: badge on button can overlap neighboring button #5860

Closed JarrettChan closed 10 months ago

JarrettChan commented 1 year ago

Bug Description

At certain widths the buttons in the Shellbar will shrink to min-width (2.25rem|2rem) from 2.5rem width, and the badge on button can overlap the neighboring button. Also "badge on button" does not match Visual Core specs for Fiori 3 or Horizon https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2698912659 https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2208784109

Expected Behavior

Badge should not overlap next button.

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/ShellBar/
  2. Change viewport width to ~1327px Notification badge 99+ overlaps profile button

Context

Log Output / Stack Trace / Screenshots

Horizon Screen Shot 2022-09-28 at 2 40 13 PM Fiori 3 Screen Shot 2022-09-28 at 2 39 39 PM Horizon Screen Shot 2022-09-28 at 2 39 24 PM Fiori 3 Screen Shot 2022-09-28 at 2 39 12 PM

Priority

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

niyap commented 1 year ago

Hello @SAP/ui5-webcomponents-topic-p,

The issue could be easily reproduced in the Playground if you smaller the width. In Horizon theme, the badge goes over the avatar, in Fiori 3, it is sticked to the avatar but not over it.

Could you please look over?

Thank you in advance!

Kind Regards, Niya

yanaminkova commented 1 year ago

Internal Reference: BGSOFUIPIRIN-5998