search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.54k stars 265 forks source link

FileUploader: add `required` and `accessibleNameRef` #5893

Open Lukas742 opened 2 years ago

Lukas742 commented 2 years ago

Feature Request Description

For screen reader support we need to be able to mark every input-like component as required and also add a label to them. For this we would need the FileUploader to accept required and accessibleNameRef.

Proposed Solution

Add required and accessibleNameRef to the component's public properties/attributes.

Additional Context

We need this for our FilterBar implementation. There it's possible to set a label for a filter and also make it mandatory (required). Per default screen readers don't read the label on top of the filter (for that we need accessibleNameRef) and if the filter is required, the input should be required as well (for that we need required).

Priority

A clear and concise description of the impact/urgency of the required feature.

Stakeholder Info (if applicable)

georgimkv commented 2 years ago

Hi @SAP/ui5-webcomponents-topic-b This is a feature request to add required and accessibleNameRef to the FileUploader. Note that there isn't a required equivalent in the corresponding OpenUI5 control. Would you have a look?

DMihaylova commented 1 year ago

Hello @Lukas742,

We'll start working on adding accessibleNameRef while for required there are internal discussions that are currently taking place.

Regards, Diana

DMihaylova commented 10 months ago

Hello @Lukas742,

We implemented accessibleNameRef. The reason for the delay of this issue is because together with the design colleagues we are working on a potential redesign of the component's look. That's a prerequisite for implementing required.