search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.52k stars 264 forks source link

avatar: make border in Horizon optional as defined in visual design spec #5965

Closed georgimkv closed 1 year ago

georgimkv commented 1 year ago

Feature Request Description

As a continuation of #5919, I request the Avatar's border which is shown in Horizon to be made optional. There's currently no way to turn it off for Horizon. The visual design spec at https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2698912516 already defines that border as "optional".

Priority

georgimkv commented 1 year ago

@SAP/ui5-webcomponents-topic-p

dobrinyonkov commented 1 year ago

ShellBar should make use of this new API to remove the avatar's border when Horizon theme is selected.

dobrinyonkov commented 1 year ago

Internal Reference: BGSOFUIPIRIN-6021

kineticjs commented 1 year ago

Hi @gmkv,

While working on this feature request I recalled that the app (or the wrapping components) can already hide the border using CSS, e.g.: .myContext [ui5-avatar] { border: none; }

just as done elsewhere in the codebase, e.g. https://github.com/SAP/ui5-webcomponents/blob/main/packages/main/src/themes/Breadcrumbs.css#L39 where the breadcrumb customizes the inner ui5-icon

So maybe we stick to this available option, as it allows to address this CSS/theming issue with CSS only, what do you think?

Thanks

kineticjs commented 1 year ago

Hi @gmkv,

We are closing this issue with recommendation to customize/remove the avatar border using CSS, as suggested in the previous comment. Please reopen if the issue should be discussed further.

Thanks