SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.48k stars 254 forks source link

[SF] Add custom ui5-cmb-item for ComboBox #6009

Open Vir-Mittal opened 1 year ago

Vir-Mittal commented 1 year ago

Feature Request Description

Related to https://github.com/SAP/ui5-webcomponents/issues/5685 and https://github.com/SAP/ui5-webcomponents/issues/5128. When the style prop is used on the combo box item, the style is not applied to the generated ui5-li. Our use case is that in the combo box, we want to distinguish between items that are a part of a group and items that are not part of a group. However, there does not seem to be any way to do so currently. Adding a custom ui5-cmb-item would allow us to style the items to do so.

Sandbox - https://codesandbox.io/s/ui5-combo-box-distinguish-grouped-items-0nc1qf?file=/index.html

Currently, this is what the combo box looks like -

Screen Shot 2022-08-17 at 2 18 07 PM

In this case, we don't want items 4, 5, 9, and 10 to be a part of any group, but visually it looks like they are a part of a group.

Priority

A clear and concise description of the impact/urgency of the required feature.

Stakeholder Info (if applicable)

TeodorTaushanov commented 1 year ago

Hi @SAP/ui5-webcomponents-topic-rl, can you check this feature request?

niyap commented 1 year ago

Hello @Vir-Mittal,

We will handle the issue as a feature request. Currently, we are working on a research for introducing custom suggestion items for the ui5-input. As we need a full UX spec to cover the feature and we might even need to create a new component to support the use case, we are currently blocked because discussions with UX are ongoing and we will depend on when they will provide a spec. Once, we did our research for the custom suggestion items support in the ui5-input and implement it, we will have more information how to continue with the custom suggestion items support in the ui5-combobox component.

Kind Regards, Niya

roy-1996 commented 1 year ago

HI @niyap @hristop We are also using the single select group combo box for one of our critical priority features.

Screenshot 2023-01-19 at 11 32 10 AM

We want to right indent the combo box items w.r.t group headers, and also want to provide a demarkation between the groups by providing a line separator.

We tried to use the style prop of both the combo box item and the combo box group item to achieve the above two requirements, but failed to do so.

Could you please provide with a timeline when the fix will be available?

roy-1996 commented 1 year ago

@hristop Any updates on this?

hristop commented 10 months ago

Hi @roy-1996 ,

Currently the situation here is the same, there are still discussions around the topic with accessibility and the UX/VD designers.

We have internal BLI related with this for the input component, which if this goes live will be pilot: BGSOFUIRILA-3433

Best Regards, Hristo

hristop commented 1 week ago

Hi,

With WebComponents 2.0 we have prepared the input components for such possibility and crated an internal BLI: BGSOFUIRILA-3872

Best Regards, Hristo