[icons] status-error and status-completed icons v4 are completely different to v5 ones

[blikblum]

Bug Description

The v4 version of status-error and status-completed icons are completely different from v5 ones. The v4 version does not resemble at all the expected visual

Expected Behavior

v4 and v5 icons should be similar / reflect the concept expected by the name

Steps to Reproduce

1. compare status-completed v4 https://github.com/SAP/ui5-webcomponents/blob/main/packages/icons/src/v4/SAP-icons.json#L1967 with v5 https://github.com/SAP/ui5-webcomponents/blob/main/packages/icons/src/v5/SAP-icons.json#L1968

The v5 one resembles a success icon, the v4 a unchecked checkbox

Isolated Example

If possible, please provide an isolated example by forking CodeSandbox.

Context

• UI5 Web Components version: 1.8.0
• OS/Platform: linux
• Browser: chromium
• Affected component: ui5-icon

Log Output / Stack Trace / Screenshots

{...}

Priority

• [ ] Low
• [x] Medium
• [ ] High
• [ ] Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

• Breaks entire application or system - High or Very High
• Accessibility issue - Medium or High
• Functional issue - Medium or High
• Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

• Organization: {...}
• Business impact: {...}

[unazko]

Hello @SAP/ui5-webcomponents-topic-p,

The reported incident is about the difference between the Fiori theme status-error and status-completed icons and the same icons in Horizon theme.

• Horizon theme:

• Fiori theme:

The situation is exactly the same in the openui5 project for the same icons between the two themes.

Best Regards, Boyan

[dobrinyonkov]

Hello @SAP/ui5-webcomponents-topic-core, could you please take over this issue?

[nnaydenow]

Hi @blikblum,

Seems to be intentional change since they appear as you reported them in OpenUI5 icon explorer.

[blikblum]

The issue occurs with the default sap_fiori_3 theme which loads v4 icon data. The icon explorer uses sap_horizon theme which loads the v5 icon data.

The issue is with v4 icon data

Here is the status-error icon source code:

import { isThemeFamily } from "@ui5/webcomponents-base/dist/config/Theme.js";
import {pathData as pathDataV5, ltr, accData} from "./v5/status-error.js";
import {pathData as pathDataV4} from "./v4/status-error.js";

const pathData = isThemeFamily("sap_horizon") ? pathDataV5 : pathDataV4;

export default "status-error";
export { pathData, ltr, accData };

[nnaydenow]

Hi @blikblum,

In version 1.11.0 icons looks to be as expected.

sap_horizon

Icon Explorer: UI5 web components:

sap_fiori_3

Icon Explorer UI5 web components:

Possible solution

We are using the SAP-icons fonts that SAPUI5 / OpenUI5 and generate SVG's on top of it. There are some icons which have similar design in both version v4 and v5 which could replace the current one. For example you can check following icons: error, alert, sys-enter-2, information for example result in: sap_fiori_3 sap_horizon

[blikblum]

Many thanks for the explanation.

I will be using horizon theme for now

The sap_fiori_3 status-error, status-completed does not resembles (at least for me) to error or completed status. Also in-progress and critical are equal. So i think that could be some kind of error.

Knowing this is the intended design, everything is fine