SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

Input: with suggestion component in Horizon theme do not meet minimum of 4.5:1 CC in default and focused states. #6068

Closed sleric1024 closed 1 year ago

sleric1024 commented 1 year ago

Describe the bug Input with suggestion component in Horizon theme do not meet minimum of 4.5:1 CC in default and focused states.

Input with Suggestion component

Isolated Example Input https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-input--with-suggestion-item

Expected behavior Icons and visual focus outline are expected to meet minimum of 4.5:1 CC in default and focused states. It may also occurs in other component as well. UI5 Control: https://ui5.sap.com/#/entity/sap.m.Select/sample/sap.m.sample.SelectWithIcons

image

Additional context Dear colleague, I am from SAP Successfactors, currently we are fixing a11y issue for b2211 release, and the issues we reported by central a11y team.

Lukas742 commented 1 year ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

dobrinyonkov commented 1 year ago

Hello @sleric1024,

those icons are considered purely decorative. They have aria-hiden="true" and role="presentation", therefore according to our accessibility standard they are included in the list of exceptions for ACC-261 - Minimum Contrast.

No minimum contrast/high contrast is required for texts, icons and visual details that are

- part of a disabled component of the user interface
- purely decorative
- logotype
- incidental to the main focus of an image or video.

Kind Regards, Dobrin

anuvenkatesh1 commented 1 year ago

Hi @dobrinyonkov In the context of our page, the icons used are "not decorative". They convey a meaning.

The "history", "filter" icons etc used here convey a meaning that user can search "from history", or "filter by" etc. Could you please reopen the ticket and consider this example where these icons are meaningful and must meet CC.

Thanks.

ilhan007 commented 1 year ago

Hello @dobrinyonkov there is an additional comment by the author, could you r someone from your team @SAP/ui5-webcomponents-topic-p follow up?

dobrinyonkov commented 1 year ago

Hello @SAP/ui5-webcomponents-topic-p, according to the visual spec, icons and text inside a dropdown should have the same color - --sapList_TextColor. Could you please take a look?