SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.52k stars 264 forks source link

Harmonize input icons style #6132

Open reqyou opened 1 year ago

reqyou commented 1 year ago

Feature Request Description

I use the Input with the prop icon={<Icon interactive />}. The Icon I use as a button to add items to a list. I also have the option enabled to delete the input content showClearIcon. When both are used together, the look and feel is very different.

Proposed Solution

From my point of view, it makes sense to add another option to say that the icon is used as a button, or derive that from <Icon interactive />, so that the interactive icon style matches the clear icon style.

Proposed Alternatives

Alternatively, a button component could be used in place of the Icon. Button transparent, however, also does not fit the clearIcon style.

Additional Context

-

Demo

GIF 02 12 2022 11-27-05

Priority

The user experience is limited.

Stakeholder Info (if applicable)

-

dimovpetar commented 1 year ago

Hello @ui5-webcomponents-topic-rl,

The complaint here is about the color of the icon in the icon slot. See the gif above or check this example https://codesandbox.io/s/ui5-webcomponents-forked-ci1gvp?file=/index.html.

Best regards, Petar

niyap commented 1 year ago

Hello @reqyou,

Thanks for sharing your findings!

Actually, the custom icons styling is a responsibility of the application developers. You can achieve it using the icon slot for applying custom styles. On the other hand, will analyse whether it is possible to style the icons used within the ui5-input component in the same way as the internally added icons.

@SAP/ui5-webcomponents-topic-rl could you please look over the requirement?

Kind Regards, Niya

hristop commented 1 year ago

Internal BLI was created: BGSOFUIRILA-3686

nnaydenow commented 2 months ago

Hello @SAP/ui5-webcomponents-topic-rl,

Since the CSS modules wasn't the best approach please take a look again over this request.