SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

[SF][ui5-upload-collection] The illustration of empty state is not consistent with Horizon design #6271

Closed i323808 closed 1 year ago

i323808 commented 1 year ago

Feature Request Description

According to https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2698916049#UploadCollection/Set(Horizon)-UploadCollection(Horizon)%E2%80%93Header, the illustration of empty state should be sapIllus-Scene-Tent.

Current illustration:

UploadCollection_empty_state

Horizon design:

UploadCollection_empty_state_design

Proposed Solution

A clear and concise description of the solution you would like to have.

Proposed Alternatives

A clear and concise description of any alternative solutions or features you've considered.

Additional Context

Add other context or screenshots related to the feature request here.

Priority

A clear and concise description of the impact/urgency of the required feature.

Stakeholder Info (if applicable)

kineticjs commented 1 year ago

Hi @SAP/ui5-webcomponents-topic-rd, The spec for Horizon https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2698916049#UploadCollection/Set(Horizon)-EmptyStates specifies a theme-specific icon for the empty state. Do you plan to reflect this in the component?

olannyv commented 1 year ago

The Upload Collection rendering for empty states is not yet using the Illustrated Messages. It is valid and nice to have, just a matter of priority and capacity in the team ....

@i323808 - what is the application or scenario where you need/expect illustrated messages?
How would you rate the priority of having such?

i323808 commented 1 year ago

Hi @olannyv ,

Thanks for your reply. We are using UploadCollection in "Apply for This Assignment" dialog of Opportunity Marketplace(SuccessFactors). We rolled out Horizon theme in the last release(b2211) and found the empty state of UploadCollection is different from other components which are using IllustratedMessage. Hopefully we can eliminate this UI inconsistency in the next release(b2305).

apply_dialog success

Thanks, Jane

olannyv commented 1 year ago

Hi, @i323808

I saw in the Spec three cases with specified Illustrated Message. How about this (/) Success screen in your last answer - what is this "Great!" Illustrated Message?

Daniel

i323808 commented 1 year ago

Hi @olannyv ,

The "Success" dialog is another business scenario which are using IllustratedMessage, so it's UI is inconsistent with the empty state of UploadCollection. The IllustratedMessage name of "Success" dialog is "BalloonSky".

BR, Jane

olannyv commented 1 year ago

Implementation BLI BGSOFUIRODOPI-2946 created Pending execution based on team capacity and priorities