SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 260 forks source link

[SF][ACC] Label Colon Not announce on NVDA #6488

Closed IrvinDelgado closed 1 year ago

IrvinDelgado commented 1 year ago

Bug Description

The label colon is not announce in NVDA when showColon = true

Expected Behavior

If label is "Name" with showColon=true then it should be announced as "Name : (announcing the word colon)"

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Label/
  2. Use NVDA to read label with showColon=true
  3. Watch as only the label is announce

Isolated Example

If possible, please provide an isolated example by forking CodeSandbox.

Context

Log Output / Stack Trace / Screenshots

Screenshot 2023-02-13 at 3 52 24 PM

Priority

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

niyap commented 1 year ago

Hello @SAP/ui5-webcomponents-topic-rd,

When the "showColon" property is set to true and colon is visualised, it is not announced by JAWS/NVDA while navigating with VPC cursor mode. I checked the OpenUI5 sap.m.Label in the same scenario and the colon is announced.

Could you please look over the issue?

Thank you in advance!

Kind Regards, Niya

TeodorTaushanov commented 1 year ago

Hi @IrvinDelgado,

The proper use of ui5-label is to define a label for elements like input, textarea, select. In that case the ui5-label is read when the focus goes to the bound element. For that the ":" (colon) should not be read, as it is just a decorative text. It should not be read even with VPC cursor mode.

ui5-label is not supposed to be used alone. In that case a regular ui5-text can be used.

Best, Teo

olannyv commented 1 year ago

Internal ticket -2995 created to improve ui5-label docu & samples