[TabContainer] Safari crashes when clicking on Tab if the tab contains Table

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.

https://sap.github.io/ui5-webcomponents/

Apache License 2.0

1.47k stars 254 forks source link

[TabContainer] Safari crashes when clicking on Tab if the tab contains Table #6591

Closed BennyHuang closed 1 year ago

BennyHuang commented 1 year ago

Bug Description

Safari browser crashes when clicking on Tab if the tab contains Table

Expected Behavior

Safari browser should crash.

Isolated Example

It can be reproduced in https://codesandbox.io/s/boring-meadow-efzoe9?file=/src/App.js

Context

UI5 Web Components version: 1.10.3
OS/Platform: MacOS Ventura 13.2
Browser: Safari 16.3
Affected component: TabContainer

Priority

[ ] Low
[ ] Medium
[x] High
[ ] Very High

The priority indicates the severity of the issue. To set the appropriate priority consider the following criteria:

Breaks entire application or system - High or Very High
Accessibility issue - Medium or High
Functional issue - Medium or High
Visual issue - Low or Medium

Note: The priority might be re-evaluated by the issue processor.

Stakeholder Info (if applicable)

Organization: SF

NHristov-sap commented 1 year ago

Hello @ui5-webcomponents-topic-rd,

I am forwarding this issue to you, because it is reproducible.

Best Regards, Nikolay Hristov

georgimkv commented 1 year ago

This is probably be related to the duplicate names for the slots in the table-cell and tab:

georgimkv commented 1 year ago

Hi @SAP/ui5-webcomponents-topic-rl

This issue seems to be related to #6570. As our colleagues pointed out in other samples, this has something to do with the rows/cells rendering. Toggling the visibility of the row causes the crash, at least in this sample https://codesandbox.io/s/sleepy-smoke-wddzrg?file=/src/App.js It is isolated from the TabContainer, as I can also reproduce this crash without using a TabContainer in this sample https://codesandbox.io/s/floral-smoke-x21eq4?file=/src/App.js. Same logic, with and without the TabContainer still causes a crash in Safari.

I also noticed that this crash doesn't occur in Safari 15:

Could you have a look?

niyap commented 1 year ago

Hello @BennyHuang,

The issue is already reported #6570 so please track the progress there. Related to #6570

Kind Regards, Niya