search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.48k stars 254 forks source link

[website][Feature Request]: Illustration explorer #6670

Open pskelin opened 1 year ago

pskelin commented 1 year ago

add the ability to see visually all illustrations to the docs

Originally posted by @pskelin in https://github.com/SAP/ui5-webcomponents/discussions/6667#discussioncomment-5238392

ilhan007 commented 1 year ago

Hi @SAP/ui5-webcomponents-topic-p it was recently raised via Github Discussion https://github.com/SAP/ui5-webcomponents/discussions/6667#discussioncomment-5238392 to have a good explorer for all illustrations in the UI5 Web Components Playground.

For the icons, we link the Icon Explorer. Not sure if there is something existing and similar for the Illustrations, that we can link from the IllustratedMessage API/sample page. If there is no existing explorer, as minimum we could enhance the sample and add a dropdown will all the options so that a user can see all illustrations (similar to the test page).

georgimkv commented 1 year ago

This is already available in Storybook. I see the samples for IllustratedMessage are already available on https://sap.github.io/ui5-webcomponents/main/_playground/?path=/story/fiori-illustratedmessage--basic The dropdown name already includes all available illustrations.

dobrinyonkov commented 1 year ago

We don't currently have dedicated explorer for the illustrations. As said, storybook adds default dropdown, but still we may do better. I will discuss with the team if it makes sense to create a fancy explorer.