SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 260 forks source link

[ui5-menu]: Title overlaps with submenu arrow #6795

Closed subint1994 closed 9 months ago

subint1994 commented 1 year ago

Bug Description

Im using ui5-webcomponents-react Menu and MenuItem for a use case. When the text in the Menu is longer, it gets overlapped with the arrow icon at the end when it has a sub menu.

Screenshot 2023-03-22 at 2 14 05 PM

Affected Component

UI5 Menu

Expected Behaviour

There should be clear gap between the end of the menu title and submenu arrow on the right.

Isolated Example

https://codesandbox.io/s/charming-river-vrz70g?file=/src/App.js

Steps to Reproduce

  1. Have some long text as a menu title
  2. Add submenus to this menu. Screenshot 2023-03-22 at 2 14 05 PM

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.10.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Declaration

petyabegovska commented 1 year ago

Hi @subint1994,

Currently, the menu is using internally the List component which truncates the long texts: see how it is with additional text (the shortcuts): image

What is exactly your use case and will the truncation work for it or you will need to show the whole text as in OpenUI5: image

Best regards, Petya

subint1994 commented 1 year ago

Hi @petyabegovska,

In my use case, I need to show the entire text as in OpenUI5 for the Menu title with submenu items.

Also is it possible to show the entire text without truncation when there is additional text also?

Regards, Subin

petyabegovska commented 1 year ago

Hi @subint1994,

Most probably we will need to refactor the control which will take time. We will research the options and may fix first the overlapping.

Best regards, Petya

sneha-ajit commented 1 year ago

@petyabegovska We are also facing the same issue. Waiting for a fix.

petyabegovska commented 1 year ago

Hi @DMihaylova and @ui5-webcomponents-topic-b,

Can you fix the overlapping?