search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 258 forks source link

[Dialog | 1.10.0 | JAWS]: Focus out of Dialog #6902

Open IrvinDelgado opened 1 year ago

IrvinDelgado commented 1 year ago

Bug Description

While on Chrome and using JAWS the user can list out buttons using the JAWS function which allows focus out of the dialog.

Affected Component

Dialog

Expected Behaviour

There should be no way to lose focus out of the dialog.

Isolated Example

No response

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/playground/components/Dialog/
  2. Start Jaws
  3. Open Dialog
  4. Press Insert+Control+B and select button outside of pop-up

Log Output, Stack Trace or Screenshots

jaws2 jaws

Priority

Medium

UI5 Web Components Version

1.10.0

Browser

Chrome

Operating System

Windows

Additional Context

No response

Declaration

ivoplashkov commented 1 year ago

Hello colleagues,

I have checked the implementation and the Dialog seems to be implemented according to the best practices - https://www.w3.org/WAI/ARIA/apg/patterns/dialog-modal/examples/dialog/.

I personally do not consider this an issue, but could you please confirm from your side as experts on the topic.

Thank you in advance! Best regards, Ivaylo

georgimkv commented 1 year ago

@TeodorTaushanov suggested we should switch to rendering the Dialog component using a <dialog> element to solve this issue:

https://codesandbox.io/s/native-dialog-element-itzkcq

https://codesandbox.io/s/ui5-webcomponents-dialog-mc5o2k

olannyv commented 1 year ago

Will be handled with internal BLI -2997

olannyv commented 7 months ago

There is internal TeamJira -2997 backlog to refactor / address this issue