SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.55k stars 266 forks source link

[Feature Request]: Support customized tokenizer container #7003

Closed yzy415 closed 6 months ago

yzy415 commented 1 year ago

Feature Request Description

Currently, we only have three ui5-webcomponents to contain the tokens. All of them put the tokens into an input box.

This is weird when we want the user to deselect the items selected from otherwhere instead of an input box. For example, we now have a page whose left panel displays the filter items and the right panel displays the results and the selected filters using tokens that can be deselected by users.

Proposed Solution

Is it possible to make a new tokenizer without the input box as the container alone?

Proposed Alternatives

I tried to make a tokenizer but found the Token component does not support providing a separate event when the close icon is clicked. I have to provide an icon button having the cross icon as a slot and do the style thing. I'm also not sure what behavior should be used in the edge case. Is there any chance we can provide a simple tokenizer without any style or at least expose the Tokenizer interface to the public?

Additional Context

I'm from SAP SuccessFactors and it's a feature with high priority.

Priority

Very High

Privacy Policy

hristop commented 1 year ago

Hi @yzy415 ,

There is "delete" event in the Token itself, however it is not public. We will look into the request and check if we can make the "delete" event public so that you can directly use it.

Best Regards, Hristo

yzy415 commented 1 year ago

Hi @yzy415 ,

There is "delete" event in the Token itself, however it is not public. We will look into the request and check if we can make the "delete" event public so that you can directly use it.

Best Regards, Hristo

Thanks and any idea or suggestion for making a tokenizer without the input box?

hristop commented 1 year ago

HI @yzy415 ,

We are waiting for final design for such control in UI5 and once we done the evaluation there, we can state if we will implement such component.

As a short term solution we can proceed with making the Token's "delete" event public so you can wrap the tokens in a container and achieve in a way a Tokenizer.

Best Regards, Hristo

yzy415 commented 1 year ago

waiting for final design for such control

Thanks @hristop, and what's the estimated time for the evaluation? If it may take longer, we can start implementing the container ourselves or reschedule our plan.

And do you have any suggestions for implementing the tokenizer?

hristop commented 1 year ago

Hi @yzy415 ,

I can't give estimation how long it will take them to make the design. We will try to include the evaluation of the token's delete event in some of our next sprints. This, we believe, will allow you to wrap the tokens in a container that you can style and achieve a standalone tokenizer in a way.

Best Regards, Hristo

yzy415 commented 1 year ago

Hi @hristop ,

just found the Tokenizer code and the 'ui5-tokenizer' webcomponent.

image

I'm curious if the "Tokenizer" can be used as an invisible container just like we want. If so, is that ok to release it to the public?

Thanks, Alex Yan

hristop commented 1 year ago

Hi @yzy415 ,

Without proper design we can't make this component public. Once we have the design ready - we can then start working in this direction, but I can be more specific only after we have the final design spec and it is clear how the component should behave.

Best Regards, Hristo

hristop commented 1 year ago

We ill start evaluation of making such public component with BGSOFUIRILA-3684. Currently there is still no ACC spec available, but we think it is being worked on, so we will start with the evaluations on our side.

hristop commented 1 year ago

Just to update everyone on the topic, there is still design work being done here and alignment of the VD / IxD and the ACC specifications. Once those are done, we will continue with the topic. For now we do not have concrete timelines from design side.

hristop commented 11 months ago

This is an update to let everyone know that we have received a spec and we will now continue with the evaluation and POC for the public tokenizer component.

hristop commented 10 months ago

Here is the P1 Jira for reference: FIORITECHP1-18033

hristop commented 6 months ago

Hi @yzy415 ,

We have introduced the Tokenizer public component with this pull request: #8484. It is available here: https://sap.github.io/ui5-webcomponents/nightly/components/Tokenizer/