search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 260 forks source link

[SegmentedButton]: Visual design is broken #7141

Closed petyabegovska closed 1 year ago

petyabegovska commented 1 year ago

Bug Description

Hi @SAP/ui5-webcomponents-topic-b,

SegmentedButton doensn't follow the visual design and looks really bad- please refer to the VD wiki page. Left and right borders are cut, but inner borders are shown.

Screenshot 2023-06-02 at 12 38 14

Morning and evening horizon themes are impacted.

Affected Component

ui5-segmented-button

Expected Behaviour

Segmented Button looks as per VD.

Isolated Example

No response

Steps to Reproduce

Open playground sample: https://sap.github.io/ui5-webcomponents/main/playground/components/SegmentedButton/

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

Latest playground + main

Browser

Chrome

Operating System

MacOS Ventura

Additional Context

No response

Organization

SAP

Declaration

petyabegovska commented 1 year ago

Update: SplitButton is also broken: https://sap.github.io/ui5-webcomponents/main/playground/components/SplitButton/

nnaydenow commented 1 year ago

Hi @petyabegovska,

Seems that the --sapButtonBorderColor parameter value is changed with https://github.com/SAP/theming-base-content/commit/3757ee0517109796d066ecc6c19b35113f4d07da and it's not regression from our side.

petyabegovska commented 1 year ago

@sapButtonBorderColor parameter has been reverted and should come with the next theming-content 11.4.3 or 11.5.0.