SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 262 forks source link

[F6Navigation | UI5WC]: Fast Navigation does not work as expected in the Learning Home Page #7201

Closed rama1990br closed 1 year ago

rama1990br commented 1 year ago

Bug Description

Fast navigation via F6 is not working as expected in Learning Home Page.

As seen in the screenshot below, data-sap-ui-fastnavgroup attribute has been added to four divs which represent four different sections on the page. However, pressing F6 skips the first two sections and only focuses on the card in the third section, and pressing F6 again results in skipping of the fourth section.

Screenshot 2023-06-14 at 10 57 42 PM

Affected Component

No response

Expected Behaviour

The expectation is that each of the four sections should receive focus on pressing F6 successively, since the implementation of all the four sections is similar.

Isolated Example

No response

Steps to Reproduce

  1. Log in to qacand (credentials provided in #sap-tech-ui5-wc-sfsf channel)
  2. Click on the module picker and click on Learning
  3. After being redirected to the learning home page, toggle the switch for "New Learning Experience" on the top-right.
  4. Execute fast navigation by pressing F6 successively and observe that the focus goes to the logo, then the banner carousel and then to "Recommended by Others" section after skipping "Required Assignments" and "Latest Bookmarks" sections. Pressing F6 again leads the focus to go back to the logo after skipping "label.AIRecommendations" section.

Link to the code where F6 is implemented for this page: https://github.wdf.sap.corp/xweb/homepage4/blob/master/src/components/HomepageSection/HomepageSection.js#L183

I wasn't able to reproduce this in the code sandbox since a lot of custom components are also being used in this page.

Log Output, Stack Trace or Screenshots

Screenshot 2023-06-14 at 10 57 42 PM

Priority

None

UI5 Web Components Version

1.9.3

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Organization

SAP SuccessFactors

Declaration

nnaydenow commented 1 year ago

As we discussed internally the F6 navigation was reworked with version 1.11.0 and the issue seems to not be reproducible there. I'm closing the issue.