Lukas742
commented
1 year ago Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.
Closed mhchem closed 1 year ago
Lukas742
commented
1 year ago Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.
didip1000
commented
1 year ago Hello @SAP/ui5-webcomponents-topic-rd,
The header background color should be @sapUiGroupContentBackground in belize, can you please check if it's set to the correct value?
Thanks, Diana
mhchem
commented
1 year ago ... and the footer Background: @sapUiPageFooterBackground border-top: 1px solid @sapUiPageFooterBorderColor respectively background: --sapPageFooter_Background; border-top: 0.0625rem solid --sapPageFooter_BorderColor;
LidiyaGeorgieva
commented
1 year ago ... and the footer Background: @sapUiPageFooterBackground border-top: 1px solid @sapUiPageFooterBorderColor respectively background: --sapPageFooter_Background; border-top: 0.0625rem solid --sapPageFooter_BorderColor;
Hello @mhchem ,
I prepared a pull request to fix the header styles. The ones in the footer that you wrote are correct and already applied. The values can be seen in this file: https://github.com/SAP/theming-base-content/blob/master/content/Base/baseLib/sap_belize/css_variables.css
The design of the dialog in Web Components project is more similar to the design of the Message dialog from openui5, than the dialog: https://sapui5.hana.ondemand.com/?sap-theme=sap_belize#/entity/sap.m.Dialog/sample/sap.m.sample.DialogMessage
Best Regards, Lidiya
LidiyaGeorgieva
commented
1 year ago Hello @mhchem,
We had an architecture and product discussion on the enablement of contrast containers in Belize for UI5 web components project. Implementing the contrast containers is complex solution, which affects multiple components - Bar, Page, Button, Dialog, Popover and other. In addition to that it is a concept that was further rejected design and technology wise and is no longer existing in newer theems. It will also bring very high complexity within the web components project. Our main goal is to keep the ui5 web components lightweight and we would avoid implementation such complex solution that affects single theme which will be soon outdated. Therefore, due to other high prio topics within the project incl. recent implementations for SAP Design system and new Horizon theme updates we cannot proceed with this request. We strongly recommend the usage of theme Horizon, which is modern and soon will be the default theme for UI5.
Best Regards, Lidiya
Describe the bug
Current implementation:
https://sap.github.io/ui5-webcomponents-react/?path=/docs/modals-popovers-dialog--docs&globals=theme:sap_belize;contentDensity:Compact
Reference implementation:
https://sapui5.hana.ondemand.com/?sap-theme=sap_belize#/entity/sap.m.Dialog/sample/sap.m.sample.Dialog
Notice the color differences for header and footer.
Isolated Example
No response
Reproduction steps
1. 2. 3. ...
Expected Behaviour
No response
Screenshots or Videos
No response
UI5 Web Components for React Version
latest
UI5 Web Components Version
latest
Browser
Chrome
Operating System
No response
Additional Context
No response
Relevant log output
No response
Declaration