SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.54k stars 265 forks source link

[Feature Request]: Expose TimeSelection #7414

Closed clemai closed 1 year ago

clemai commented 1 year ago

Feature Request Description

Is there any chance to get the 'ui5-time-selection-clocks' or 'ui5-time-selection' component exposed as standard web components as well? If I looked correctly, these components are private right now.

Within our app, we are having a ui5-multi-input component with custom value help popover. Within this popover a date selection (via ui5-calendar) and a time selection shall be possible.

Proposed Solution

Like said in the description above, making one of the ui5-time-selection public would prevent us from rebuilding it.

Proposed Alternatives

No response

Organization

SAP SIX Technologies

Additional Context

No response

Priority

Medium

Privacy Policy

LidiyaGeorgieva commented 1 year ago

Hello @SAP/ui5-webcomponents-topic-b, take a look of this feature request.

tsanislavgatev commented 1 year ago

Hello @clemai ,

Did you check the DateTimePicker control? https://sap.github.io/ui5-webcomponents/playground/?path=/docs/main-datetimepicker--docs It serves a similar purpose to what you are trying to build?

I am currently not aware of plans related to releasing the time selection part as a stand alone public control.

Best Regards, Tsanislav

clemai commented 1 year ago

Hi @tsanislavgatev ,

thanks for looking into it! Yes, I am aware of the DateTimePicker control and we already using it in other places.

Why we still need the TimeSelection to be exposed is that we want have the DateTimePicker Popover content (Calendar + TimeSelection) wrapped into a TabContainer control within our own Popover, like the following structure:

<MultiInput />
<Popover>
  <TabContainer>
     <Tab>
        <Calendar />
        <TimeSelection />
     </Tab>
     <Tab>
        <CustomExtension />
     </Tab>
  </TabContainer>
</Popover>

Is exposing the whole DateTimePicker Popover content as separate control an option for you? Do you have a any idea or hint for me how build such a popover with the already exposed controls?

github-actions[bot] commented 1 year ago

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!

tsanislavgatev commented 1 year ago

Hello,

As we are still researching if there is a way to make the component public as it currently the time selection component is only a building part for the (Date)TimePicker. A proposal that we can make is to have the DateTimePickerPopover able to be opened by other things than the input, like button. If this proposal doesn't work, we can take it as feature request and continue with the discussions about making it public, which might take some time.

github-actions[bot] commented 1 year ago

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!

github-actions[bot] commented 1 year ago

Hello, everyone! The issue has been inactive for 28 days, so I am closing the issue.

clemai commented 1 year ago

Hi @tsanislavgatev , I've not seen your update and this topic is still relevant to us.

Your proposal doesn't work for us, since we need to have this custom content (e.g. Tab Container) within the Popover.

Could you handle this topic as feature request then?