search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

[Bar]: When using as Dialog Header with a state Border is incorrect #7418

Closed i832513 closed 1 year ago

i832513 commented 1 year ago

Bug Description

When we use a as the title of a Dialog, and we set a state on the Dialog, the border color of the header is incorrect.

As a work around we implemented a custom Bar React component that we use in place of the Bar, but we much prefer to use the Bar component instead.

Affected Component

Bar

Expected Behaviour

When the Bar is placed inside a Dialog as the custom header, the border on the Bar should not interrupt the border added by the Dialog itself.

Isolated Example

https://codesandbox.io/s/ui5-webcomponents-forked-rt3dcy

Steps to Reproduce

  1. Have a Bar in a Dialog's header slot and make sure to set the state of the Dialog to "error"

Log Output, Stack Trace or Screenshots

N/A

Priority

Medium

UI5 Web Components Version

1.16.0

Browser

Chrome

Operating System

No response

Additional Context

Dialog custom headers will almost universally use a Bar for the header.

Organization

SuccessFactors

Declaration

LidiyaGeorgieva commented 1 year ago

Hello @SAP/ui5-webcomponents-topic-rd ,

The issue is reproducible and is related to the usage of ui5-bar in ui5-dialog.

Best Regards, Lidiya

s-todorova commented 1 year ago

Hello @i832513,

The issue has been fixed with the linked PR and will be available with the next WC version 1.18.

Best regards, Siyana