SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.47k stars 254 forks source link

[SF][A11Y][RadioButton]: Interactive Controls Must not Be Nested #7419

Closed rama1990br closed 10 months ago

rama1990br commented 11 months ago

Bug Description

Hi Team, When using ui5-radio-button component and running "axe Dev Tools" browser extension to scan the page to test a11y issues, the following issue is detected. Please take a look. Thanks!

Screenshot 2023-08-07 at 8 52 18 AM

Affected Component

RadioButton

Expected Behaviour

We shouldn't be getting the above a11y error.

Isolated Example

No response

Steps to Reproduce

  1. Go to https://qacand.hcm.ondemand.com/sf/scriptintegrationsettings page. Will share the credentials in the slack channel
  2. Add chrome extension "axe devTools"
  3. Scan the entire page

You can find more information on this issue here: https://dequeuniversity.com/rules/axe/4.5/nested-interactive?application=axeAPI

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.14.2

Browser

Chrome

Operating System

Mac OS Ventura 13.4.1

Additional Context

No response

Organization

No response

Declaration

LidiyaGeorgieva commented 11 months ago

Hello @SAP/ui5-webcomponents-topic-rd ,

The issue is reported for "axe Dev Tools" chrome extension, but I tested with "Access assistant" tool and there is similar issue: image image I used this page for testing: https://sap.github.io/ui5-webcomponents/nightly/playground/main/pages/RadioButton/?sap-ui-theme=sap_horizon

Please have a look.

Best Regards, Lidiya

rama1990br commented 10 months ago

Hi Team, can we please get an update on this issue?

rama1990br commented 10 months ago

@gmkv Which version of ui5-webcomponents do I need to upgrade to in order to get this issue fix?

georgimkv commented 10 months ago

Hi @rama1990br The latest available version includes the fix: https://github.com/SAP/ui5-webcomponents/releases/tag/v1.17.0