search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 258 forks source link

[Side Navigation]: Click on active nav item not triggered when navigation is collapsed #7431

Closed doruskova closed 10 months ago

doruskova commented 1 year ago

Bug Description

Click on the active tab doesn't do anything when the side panel is in collapsed mode.

Affected Component

Side Navigation

Expected Behaviour

As a user I want to have my navigation collapsed and click on the active item so that it can bring me back to the main page .

Isolated Example

No response

Steps to Reproduce

  1. Collapse the side navigation
  2. Go to the sub-item page (main page)
  3. Go to a detail's page of the sub-item
  4. Click on the sub-item in the popover again to get the main page
  5. Nothing happens after clicking on the item ...

Log Output, Stack Trace or Screenshots

Not being able to click on the selected item to get the main object page.

https://github.com/SAP/ui5-webcomponents/assets/32618096/21c1a0fc-be54-4c4c-8af4-6ecb20346302

Priority

Medium

UI5 Web Components Version

v1.18.0

Browser

Chrome, Edge, Firefox, Safari

Operating System

macOS Ventura 13.5

Additional Context

No response

Organization

SAP Signavio

Declaration

LidiyaGeorgieva commented 1 year ago

Hello @SAP/ui5-webcomponents-topic-rd ,

Please check if this is part of the new interaction design, which will be implemented soon, or it is separate bug. Link: https://sap.github.io/ui5-webcomponents/nightly/playground/?path=/story/fiori-side-navigation--tool-layout&globals=theme:Morning%20Horizon%20Preview

Best regards, Lidiya

doruskova commented 1 year ago

Hey @LidiyaGeorgieva. Thank you so much for such a fast reply. :) The bug is still there. It's not possible to click on the active item.

LidiyaGeorgieva commented 1 year ago

@doruskova , Just to clarify: the issue you report is that when you click on the selected sub item, nothing happens and the popover doesn't closes, wright? If you click on the sub item, which is not selected, the popover closes and this is the expected behavior?

doruskova commented 1 year ago

@LidiyaGeorgieva I expect that the selected item is still clickable and takes me to the main page. Now, it's not clickable at all. But, our consultants expect that the link is available all the time. Not only once when the item or subitem is not selected. The same issue was opened some time ago https://github.com/SAP/ui5-webcomponents/issues/3333

TeodorTaushanov commented 10 months ago

This issue is fixed in the main branch with #7682