search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.52k stars 263 forks source link

[FilterBar]: Missing tooltip for List View Segmented Button #7435

Open FirstOrangutan opened 1 year ago

FirstOrangutan commented 1 year ago

Describe the bug

In the Filters dialog (to select, de-select filter bar fields), the Segmented button to toggle between Group and List view is missing a tooltip for List View. This can also be observed on the example provided over at - https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-filterbar--docs

There is also a codesandbox example attached below.

Isolated Example

https://codesandbox.io/s/strange-aryabhata-44rhfh?file=/src/App.js:1168-1177

Reproduction steps

  1. Click on Filters
  2. Hover over Group icon on the Segmented Button - 'Group' tooltip appears
  3. Select Group and hover over list icon - ' No tooltip is shown' ...

Expected Behaviour

Similar to Group, when list icon is hovered over, a tooltip is shown.

Screenshots or Videos

https://github.com/SAP/ui5-webcomponents-react/assets/46435477/608a606d-c35f-493a-8c70-66c296838c0b

UI5 Web Components for React Version

1.18.0

UI5 Web Components Version

1.16.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Declaration

MarcusNotheis commented 1 year ago

Hi @FirstOrangutan,

Thanks for reporting! After looking into the issue, it looks like that this issue is caused by the Icon Component which is developed in the UI5 Web Components repository, so I'll forward this issue.

Hi colleagues,

the ui5-icon with the name list is not providing any accessibility data by default so no tooltip is shown for this icon. Would it make sense to add some default accessibility tests for this icon as well?

If this is not the case, can you forward to accessible-name attribute of the ui5-segmented-button-item to the internal icon in order to enable the tooltip?

LidiyaGeorgieva commented 1 year ago

Hello @SAP/ui5-webcomponents-topic-b ,

Reported problem is that the icons in the segmented button doesn't always have tooltips. Some Icons have aria-label, which is visualized as a tooltip, but some haven't. There are two possible solutions of the problem:

  1. request all icons to have aria label text like "group-2" has: image This should be aligned with the ACC experts, team Pirin (ui5-icon) and team Core

  2. request to the ui5-segmentedbutton to have new property for providing tooltip for the Icon (or to change the default tooltip) Example: https://sap.github.io/ui5-webcomponents/nightly/playground/?path=/story/main-segmentedbutton--with-icons&args=accessibleName:SOmeString

Best Regards, Lidiya

FirstOrangutan commented 11 months ago

Hi Colleagues, I can see that message was forwarded due to incorrect component. Apologies for that, however I wanted to check if this is still planned to be taken up in future?

Thanks

FirstOrangutan commented 9 months ago

Hi Colleagues @LidiyaGeorgieva @MarcusNotheis This issue was transferred last year in August but then removed from the roadmap in September. I tried to follow up but it seems like this issue is not monitored anymore, therefore I had to tag you individually to seek some advice.

Can you please advice for the next course of action? Will this issue be taken up anytime in the future or is it already fixed/taken up? If needed, I can open a new issue with the correct component - in this case please let me know if it should be @SAP/ui5-webcomponents-react or @SAP/ui5-webcomponents-topic-b

Thank you and regards