SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.47k stars 254 forks source link

[Panel | Example with buttons in custom panel are arranged not according to our product standard] #7465

Closed MarvinGille closed 10 months ago

MarvinGille commented 10 months ago

Bug Description

According to primary action should be on the left for LTR languages:"Products must place primary actions in reading direction before other actions."

In current Fiori for Web guidelines advise against using emphasized and semantic buttons together:

The buttons in panels with custom header should be arranged like this:

Add [emphasized], Remove [default], Block [default]

Affected Component

Panel

Expected Behaviour

Arrange buttons in this order:

Add [emphasized], Remove [default], Block [default]

Isolated Example

https://sap.github.io/ui5-webcomponents/playground/?path=/story/main-panel--panel-custom-header

Steps to Reproduce

  1. Button Add [emphasized]
  2. Button Remove [default] 3.button Block [default] ...

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

v1.16.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

sap

Declaration

MarvinGille commented 10 months ago

It should like this in panel w/ custom header:

Add Remove Block

Still, the storybook shows old example...

MarvinGille commented 10 months ago
Screenshot 2023-08-22 at 11 41 49