SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.56k stars 267 forks source link

Link - need support for title property #7518

Closed pankajpandey01 closed 1 year ago

pankajpandey01 commented 1 year ago

Is your feature request related to a problem?

This feature request is related to a11y requirement where user need to be informed about the link which will open in window/tab

Describe the solution you'd like

Title property should be supported where we can provide extra info to user (in our case "info about link opening in new window"). This will help visual user as well as screen reader user.

For example:

<Link title="Link open in new window/tab">
  Link Text
</Link>

Describe alternatives you've considered

No response

Additional Context

Organization: {SuccessFactors}

Declaration

MarcusNotheis commented 1 year ago

Hi @pankajpandey01,

this feature is already supported as the Link component (like almost every other component in this project) is accepting all standard HTML attributes which includes title as well.

Example CodeSandBox: https://codesandbox.io/p/sandbox/wcr-link-title-qgwntm?file=/src/App.tsx:1,24

pankajpandey01 commented 1 year ago

Hi @MarcusNotheis, title attribute added on is not getting added to inner tag. So screen reader JAWS 2023 not announcing it. Screenshot 2023-08-30 at 10 28 18 AM

MarcusNotheis commented 1 year ago

Thanks for the explanation, I didn't get that this issue was about Screen Readers from the initial description. As the Link component is developed in the UI5 Web Components repository, I'll now forward this issue to their repository.