SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.55k stars 266 forks source link

[SF][A11Y][Switch]: Interactive Controls Must not Be Nested #7554

Closed rama1990br closed 5 months ago

rama1990br commented 1 year ago

Bug Description

Hi Team, The following issue related to ui5-switch component is seen when running "axe Dev Tools" browser extension to scan the page to test a11y issues. Please take a look. Thanks!

Screenshot 2023-09-05 at 4 28 12 PM

Affected Component

Switch

Expected Behaviour

We shouldn't be getting the above a11y error.

Isolated Example

https://sap.github.io/ui5-webcomponents/nightly/playground/main/pages/Switch/?sap-ui-theme=sap_horizon

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents/nightly/playground/main/pages/Switch/?sap-ui-theme=sap_horizon
  2. Add chrome extension "axe devTools"
  3. Scan the entire page

You can find more information on this issue here: https://dequeuniversity.com/rules/axe/4.5/nested-interactive?application=axeAPI

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.17.0

Browser

Chrome

Operating System

Mac OS Ventura 13.4.1

Additional Context

No response

Organization

SAP SuccessFactors

Declaration

dimovpetar commented 1 year ago

Hello @SAP/ui5-webcomponents-topic-b ,

Please take a look at this reproducible issue. It looks the same as https://github.com/SAP/ui5-webcomponents/issues/7419

Best regards, Petar

rama1990br commented 1 year ago

Hi Team, Can we please get an update on this?

rama1990br commented 1 year ago

Hi @dimovpetar, Can we please get an update on this ticket?

tsanislavgatev commented 1 year ago

Hello @rama1990br ,

Your issue is in the dev team that's working on switch and we will get back to you once we have more information.

Best Regards, Tsanislav

hinzzx commented 5 months ago

Hello @rama1990br ,

I runned the Axe DevTool both locally and on the dev samples page, with Best Practicses mode On and Off, following standard WCAG 2.1 AA and the reported issue is no longer reproducible.

Best Regards, Stoyan