search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 260 forks source link

Button: The button component is missing a way to add accessible role of link #7612

Closed ekeyur closed 6 months ago

ekeyur commented 12 months ago

Describe the bug

Many time buttons and links are used interchangeably, We need a way to add an accessible role of link to button if it actually behaves as a link.

Isolated Example

No response

Reproduction steps

1. 2. 3. ...

Expected Behaviour

Just need a way to add role of a link to the button component.

Screenshots or Videos

No response

UI5 Web Components for React Version

1.17.3

UI5 Web Components Version

1.15.1

Browser

Chrome, Edge, Firefox, Safari

Operating System

MAC OS

Additional Context

No response

Relevant log output

No response

Declaration

Lukas742 commented 12 months ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

plamenivanov91 commented 12 months ago

Hello @SAP/ui5-webcomponents-topic-b,

The app developer would like to have the option to add an accessible role of link to button.

Is this feasible feature request? Can you please take over?

Regards, Plamen Ivanov

tsanislavgatev commented 11 months ago

Hello colleagues,

This is a feature request. We have the same functionality in openui5. Can you please check and evaluate this feature.

Best Regards, Tsani

ekeyur commented 11 months ago

Can this functionality be implemented on ui5-webcomponents-react as well, since that is the library we are now using.

Lukas742 commented 11 months ago

Hi @ekeyur

since UI5 Web Components for React only wraps ui5 web components, all features and bug fixes will be available out of the box. When a new @ui5/webcomponents minor version is available, we will update our project (@ui5/webcomponents-react) timely to support the new version. (Usually this takes only a few days at most)