SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.48k stars 254 forks source link

[Input]: ValueStateMessage is getting read by the reader instead of input data, even though valueState is None #7645

Open vedanshiPatel opened 9 months ago

vedanshiPatel commented 9 months ago

Bug Description

Issue: For the Input - ValueStateMessage is getting read by the reader instead of input data, even though valueState is None.

Affected Component

Input

Expected Behaviour

The valueStateMessage should not be read by the reader when valueState is None.

Isolated Example

No response

Steps to Reproduce

1. 2. 3. ...

Log Output, Stack Trace or Screenshots

Screenshot 2023-09-29 at 10 59 30 AM Screenshot 2023-09-29 at 11 00 17 AM Screenshot 2023-09-29 at 11 02 10 AM

Priority

High

UI5 Web Components Version

ui5/webcomponents-react@1.9.2

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

SAP

Declaration

georgimkv commented 9 months ago

Hi @vedanshiPatel Could you share which organization within SAP are you from?

georgimkv commented 9 months ago

Hi @SAP/ui5-webcomponents-topic-rl This issue is about the input's value state message always being announced when that input is placed inside a Table.

To reproduce:

  1. https://codesandbox.io/s/ui5-webcomponents-forked-7vlcyn?file=/index.html
  2. Focus the table row (turn VPC off) and hear the screen reader announcement.

The first input in the sample has value-state="None" and the third input has value-state="Error". Both value state messages get announced when the table row contents are being read. The expectation is that the input with value-state="None" should not have its message announced. Tested with Windows 11 and JAWS 2023.2307.37.

Would you check this?

vedanshiPatel commented 9 months ago

Could you share which organization within SAP are you from?

Industry Cloud

elenastoyanovaa commented 7 months ago

Hello @vedanshiPatel ,

Thank you for reporting the issue. I am the accessibility expert of the team owning the table component. I have analysed the issue and it is indeed a case which we didn't have in mind when implementing the speech output on row level. Unfortunately a quick fix cannot be performed on table level as we need to have a context for each component and what needs to be read out of it and what not. This is the missing part here. I deep dived and I requested a feature on core framework level which will solve the issue in future. I have described it here: https://github.com/SAP/ui5-webcomponents/issues/8022

After implementing it and later adopting it in the ui5-table only the relevant information will be read out when a row is focused.

In order to not have the issue on your side I would suggest you remove the content of the value state message slot and add it with the value state update only.

You can track the progress of the issue I linked. Thank you for reporting!

Kind Regards, Elena

hristop commented 7 months ago

Hi, I am moving this to the Feature requests section as we need to plan and develop it properly once #8022 is done in by the core team.