[Input][ComboBox] Ability to have customizable border radius

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.

https://sap.github.io/ui5-webcomponents/

Apache License 2.0

1.51k stars 263 forks source link

[Input][ComboBox] Ability to have customizable border radius #7680

Closed emilylian-sap closed 11 months ago

emilylian-sap commented 12 months ago

Is your feature request related to a problem?

Input and ComboBox have square borders by default. We would like the ability to define the border-radius value ourselves. The border-radius of the Input can be styled using jss but the dotted line shown on focus is not styleable since its inside CSS Shadow DOM.

Describe the solution you'd like

Have a new API that allows consumer to define the border radius.

Describe alternatives you've considered

Expose input content as CSS Shadow Part so it becomes styleable.

Additional Context

No response

Declaration

[X] I’m not disclosing any internal or sensitive information.

Lukas742 commented 12 months ago

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

Todor-ads commented 11 months ago

Hello @SAP/ui5-webcomponents-topic-rl, take a look of this feature request.

Best regards, Todor

hristop commented 11 months ago

Hi @emilylian-sap ,

After sync with our UX / VD colleagues, we will have to reject this requirement. In general, the shape of the controls is related to the accessibility standards that we need to adhere to and changing it will result in deviation. The radius itself is parsed via parameter which is theme-able through the Theme Designer but this is done a scale, not per component.

Best Regards, Hristo