search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.51k stars 262 forks source link

[Feature Request]: IllustratedMessage - expose part for subtitle div #7879

Closed Vir-Mittal closed 6 months ago

Vir-Mittal commented 10 months ago

Feature Request Description

The illustrated message right now comes with the option of adding a subtitle as a slot. However, this slot is under the following div in the shadow root of the illustrated message -

And has the css property of max-width being 20rem

Would it be possible to expose this div as a part so that we can adjust the max-width of the text.

Basically right now we have something that looks like -

Screenshot 2023-11-20 at 11 34 56 AM

But want to get something that looks like -

Screenshot 2023-11-20 at 11 35 21 AM

Proposed Solution

Expose the shadow root div as a part so that the css can be modified

Proposed Alternatives

No response

Organization

SuccessFactors

Additional Context

No response

Priority

Medium

Privacy Policy

MapTo0 commented 10 months ago

Hello @SAP/ui5-webcomponents-topic-p ,

This is a feature request to expose a part for the subtitle slot's wrapper so the use can enlarge the max-width.

While looking in the feature request I have also spotted a few issues with the Horizon implementation. Subtitle has max-width: 30rem which is incorrect based on the Horizon spec.

Best Regards, Martin

dobrinyonkov commented 8 months ago

Hello @Vir-Mittal, your request was implemented with #8088. The issue mentioned by Martin will be handled with a seprate PR.

Kind Regards, Dobrin

Edit: FR is implemented, only the visual issues described in the above comment remain unsolved. Moving to maintenance for implementing a fix.