search

SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.47k stars 254 forks source link

[Feature Request]: Input with SuggestionItem - improve announcement #7880

Open yzy415 opened 7 months ago

yzy415 commented 7 months ago

Feature Request Description

The announcement of our component is good enough and behaves like OpenUI5's. However, some behaviors are still obstacles to the SR users. There are some suggestions to improve it:

  1. add announcement "expand" when the dropdown for suggestions expands as Google and Microsoft do.
  2. rephrase the announcement of the count of suggestions when they're segmented into different groups, for the suggestions in the pictures below, it should be announced as "3 some countries and 3 some other countries are available" instead of "6 results available". It's feedback from a real SR user.
  3. Do not announce "no results" when there is no result. It's useless for the SR user to know there is no result. In a real case where the suggestions request is sent every time the user is typing, we need to clear the stale results first before we get the new ones. The "no results" will keep being announced, but it's meaningless for the user to know we have no suggestions available.
  4. Do not announce "suggestions available" when the user tabs to the search box. For now when the user tabs to the search box, the SR will announce like "type anything to show suggestions edit has auto complete Suggestions available blank". It's misleading. image

Proposed Solution

  1. add announcement "expand" when the dropdown for suggestions expands
  2. rephrase the announcement of the count of suggestions when they're segmented into different groups
  3. Do not announce "no results" when there is no result.
  4. Rephrase the announcement when the user tabs to the search box.

Proposed Alternatives

No response

Organization

SAP SuccessFactors

Additional Context

https://codesandbox.io/s/crazy-sun-vxcl3h?file=/src/App.tsx You can use the sandbox above to reproduce. In this instance, when the user types, a mock request will be sent.

Priority

Medium

Privacy Policy

MapTo0 commented 7 months ago

Hello @SAP/ui5-webcomponents-topic-rl ,

Take a look of this ACC improvement proposal for Suggestions.

Regards, Martin

elenastoyanovaa commented 7 months ago

Hello @yzy415 ,

As you noted the current implementation behaves as the OpenUI5 control, because they follow the same screen reader specification. As I do not see real issues, but suggestions for improvement I think that this is rather a feature request, rather a bug. We need to evaluate every use case you mentioned and discuss them with the accessibility team. When we have updates we will get back to you.

Thank you for testing and reporting your findings!

Kind Regards, Elena Accessibility Expert

anuvenkatesh1 commented 7 months ago

Hi Team,

The issues were identified as potential misleading announcements by "a blind user" who used our page. Hence thank you for taking these into consideration as feature requests. Is there any ETA for the the feature request?

hristop commented 7 months ago

Hi @anuvenkatesh1 ,

Currently we can't give ETA as these points need to be discussed with our ACC experts. Then based on the discussions we will need new ACC specs for the controls created / updated and after that we can implement them in both the WebComponents and UI5.

I guess we will have more info JAN next year (due to the holidays season coming and lower capacity / expert availability).

hristop commented 3 weeks ago

Hi @yzy415 ,

We have discussted the 4 points internally and here is an update for all of them:

  1. We have created feature request to our design colleagues, so they can look into the requirement and validate it: FIORITECHE1-8305
  2. We have created feature request to our design colleagues, so they can look into the requirement and validate it: FIORITECHE1-8306
  3. We will look into why this occurs and will provide further feedback
  4. We will have to reject this requirement. We cannot remove the "... Suggestions available... " part of the screen reader announcement as this is how we tell the users that this input can have suggestions. In future, when we allow custom items to be provided to the input, such can be created and the invisible messaging service used in order for custom announcements to be made. Then the applications can decide what exactly to convey to the users.

Best Regards, Hristo