SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 258 forks source link

[UI5 Web Components 2.0] Changes suggestion list [Topic P] #7887

Open ilhan007 opened 9 months ago

ilhan007 commented 9 months ago

Issue Description

The goal is to gather a list with breaking changes that you are willing to do to improve/simplify the components API.

There is already this issue https://github.com/SAP/ui5-webcomponents/issues/4460 with changes we already identified, so first take a look of it - it could be that some of your suggestions are already proposed.

dobrinyonkov commented 6 months ago

Internal Reference: BGSOFUIPIRIN-6407

IllustratedMessage

Progress Indicator

Select Option

SelectMenu

Toolbar

TreeItem

Decision => remains as it is to avoid fighting properties - the slot vs the props

Flexible Column Layout

Decision => remains as it is, as the drag and drop feature is unlikely to become available for 2.0. Remains candidate for later major version.

ShellBar

TODO [Team Pirin]

=> property to show/hide (as showCoPilot) or to get Joule's Dom ref (as copilotDomRef) may remain, but we need to check how to name it properly avoiding using "Joule" as concepts often changes. Explore the options to keep using co-pilot, if this will cause confusion or digital assistant. => the option to provide slot is the most flexible, the users should then provide toggle-button with "da" icon, which is not bad, but you have to maintain certain position and make sure it never overflow and again give the slot name, which we could not find a generic name for. Feel free to suggest solution in this direction as well.

nnaydenow commented 6 months ago

Investigate how we can simplify ListItems' hierarchy

dobrinyonkov commented 6 months ago

With the modern themes, the List modes values seems to be just 3 now. Deprecate the redundant ones:

image

Decision: => options remain as it turns out SingleSelect and SingleSelectAuto have different behaviour.

Changes: => rename SingleSelectBegin to SingleStart SingleSelect to Single MultiSelect to Multiple SingleSelectEnd to SingleEnd

ilhan007 commented 6 months ago

Transferring from the central item

"Deprecate and remove the image property of the standard list item, since new slot avatar will be introduced. https://github.com/SAP/ui5-webcomponents/issues/5594"

Changes: => remove property image => rename slot imageContent to image

ilhan007 commented 5 months ago

Extarnal feedback

ui5-breadcrumbs:

Changes: => rename separator-style to separators.

ui5-illustrated-message:

Changes: => change size to design.

ui5-list

Changes: => rename busy to loading => rename mode to selectionMode => ListMode : SingleSelect -> Single, MultiSelect -> Multiple => rename ListMode to ListSelectionMode