SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.55k stars 266 forks source link

[TextArea]: growingMaxLines property only seems to work until a certain value #7930

Closed Vir-Mittal closed 10 months ago

Vir-Mittal commented 11 months ago

Bug Description

For the tex area component, when we set the growing property to true and the growingMaxLines to a certain number, we expect that number of lines to be visible before a scrollbar shows up

For example - When growingMaxLines is 4, 4 lines are shown -

Screenshot 2023-11-28 at 8 27 29 AM

When its 7, 7 lines are shown -

Screenshot 2023-11-28 at 8 27 44 AM

But, when its 8 or any number greater than 8, still only 7 lines are shown -

Screenshot 2023-11-28 at 8 28 04 AM

Tested using https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-textarea--docs

Affected Component

TextArea

Expected Behaviour

growingMaxLines property should work as expected

Isolated Example

No response

Steps to Reproduce

  1. Go to https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-textarea--docs
  2. Input a large text in the text area
  3. Change the growingMaxLines value

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

1.19.0

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Organization

SAP SuccessFactors

Declaration

GerganaKremenska commented 11 months ago

Hello @Vir-Mittal,

Can you retest the issue? As it is not reproducible now on: https://sap.github.io/ui5-webcomponents-react/?path=/docs/inputs-textarea--docs

Or are there any steps different from setting "growing": true, and changing the number of "growingMaxLines"?

Best Regards, Gergana

github-actions[bot] commented 10 months ago

Hello, everyone! The issue has been inactive for 21 days. If there are still questions or comments, please feel free to continue the discussion. Inactive issues will be closed after 7 days!

github-actions[bot] commented 10 months ago

Hello, everyone! The issue has been inactive for 28 days, so I am closing the issue.