SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.5k stars 260 forks source link

[SegmentedButton]: Segment sizes are independent of text length #7955

Open sebkaim opened 9 months ago

sebkaim commented 9 months ago

Bug Description

In the SegmentedButton for instance, the individual segments take the length of the copy + padding according to the visual specs.

Visual Specs image002

Yet, In the implementation, all button segments have the same size.

image003

Affected Component

SegmentedButton

Expected Behaviour

The individual segments (buttons) within a segmented button should take the length of their label, and not adopt the longest length fo all segments in a uniform way.

Isolated Example

No response

Steps to Reproduce

See example images on top;

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.5.0

Browser

Chrome

Operating System

Mac

Additional Context

No response

Organization

SAP Signavio

Declaration

ilhan007 commented 9 months ago

Hello @SAP/ui5-webcomponents-topic-b could you check this, I think having the same size was something intentionally built.

tsanislavgatev commented 7 months ago

Yes, the default behaviour of the SegmentedButton is having equally sized items. But we've had discussions with designers and we are working on implementing a new, additional behaviour of the SegmentedButton where the Items will be fit-content.

sebkaim commented 7 months ago

[like] Kaim, Sebastian reacted to your message:


From: Tsanislav Gatev @.> Sent: Tuesday, February 6, 2024 1:48:32 PM To: SAP/ui5-webcomponents @.> Cc: Kaim, Sebastian @.>; Author @.> Subject: Re: [SAP/ui5-webcomponents] [SegmentedButton]: Segment sizes are independent of text length (Issue #7955)

Sie erhalten nicht oft eine E-Mail von @.*** Erfahren Sie, warum dies wichtig isthttps://aka.ms/LearnAboutSenderIdentification

Yes, the default behaviour of the SegmentedButton is having equally sized items. But we've had discussions with designers and we are working on implementing a new, additional behaviour of the SegmentedButton where the Items will be fit-content.

— Reply to this email directly, view it on GitHubhttps://github.com/SAP/ui5-webcomponents/issues/7955#issuecomment-1929668089, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BEPHHTLOCI3UEGQQM6PEZATYSIYDBAVCNFSM6AAAAABAHYJGR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRZGY3DQMBYHE. You are receiving this because you authored the thread.Message ID: @.***>