SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.55k stars 266 forks source link

[StepInput]: double clicking add or delete button selects text in other element #8026

Closed QiuranHu closed 8 months ago

QiuranHu commented 10 months ago

Bug Description

Double clicking add or delete button selects text in other element

To reproduce, go to the demo page for StepInput (https://sap.github.io/ui5-webcomponents/playground/?path=/docs/main-stepinput--docs).

Double click the add button. Check if "show" text is selected.

Screenshot 2023-12-20 at 14 44 47

Also in edge browser when clicking very fast, only some clicks leads to an increase in value. Some clicks have no effect. Please see the video attached. https://github.com/SAP/ui5-webcomponents/assets/55808904/e777037a-acc5-4540-899a-a7f8d3ffbef0

Affected Component

StepInput

Expected Behaviour

No response

Isolated Example

No response

Steps to Reproduce

1. 2. 3. ...

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.17.4

Browser

Edge

Operating System

No response

Additional Context

No response

Organization

SuccessFactors

Declaration

hinzzx commented 8 months ago

Hi @QiuranHu,

I've tested and observed the reported issue and it seems that this is a default browser behaviour, as it could be observed in all of our Input-based components (like ComboBox, DatePicker, etc.). The behaviour is observed in most of the Browsers (tested in Chrome & Edge), except Firefox. Therefore I am closing this issue as it seems that it is not ours to fix.

Edge:

https://github.com/SAP/ui5-webcomponents/assets/88034608/30f0a4e8-1f50-432c-b0ff-d648e05e0949

Chrome:

https://github.com/SAP/ui5-webcomponents/assets/88034608/7818835c-085f-4389-b90d-1d9a769a316e

Please let me know if I could assist you with anything further!

Best Regards, Stoyan

QiuranHu commented 8 months ago

Hi @hinzzx , Thanks for replying! I checked ui5 and other component library that provides similar functionality (buttons for increment/decrement) and they do not have this issue. Please see ui5, material ui and antd.

For this component, user might click the button multiple times in a short time frame. Double clicking the increment button should not select texts, because it hurts user experience. Also in edge, when you double click it, there will be a popup shown and further clicks will be blocked for a while. Screenshot 2024-03-06 at 11 28 48

So I think we can try add a preventDefault when handling click event, like in this issue(https://github.com/SAP/ui5-webcomponents/issues/7236).

Qiuran Hu

hinzzx commented 8 months ago

Hi @QiuranHu,

Thank you for the input! In that case I will investigate it further, and am re-opening the incident.

BR, Stoyan