SAP / ui5-webcomponents

UI5 Web Components - the enterprise-flavored sugar on top of native APIs! Build SAP Fiori user interfaces with the technology of your choice.
https://sap.github.io/ui5-webcomponents/
Apache License 2.0
1.47k stars 254 forks source link

[IllustratedMessage]: Not displaying correct illustration #8145

Open OliwiaGowor opened 5 months ago

OliwiaGowor commented 5 months ago

Bug Description

Hello, When using IllustratedMessage component importing illustration like this, according to the documentation: import "@ui5/webcomponents-fiori/dist/illustrations/tnt/NoApplications.js", and calling the component:

<IllustratedMessage
name="TntNoApplications"
size="Scene"
subtitle={"Subtitle"}
>

causes to display this illustration: image (1) instead of the one shown in the documentation: image

But when I import all illustrations like this import @ui5/webcomponents-fiori/dist/illustrations/AllIllustrations the proper illustration is displayed. image (2)

I don't want to have to import all of the illustrations to display just one of them.

Affected Component

IllustratedMessage - "TntNoApplications" illustration

Expected Behaviour

IllustratedMessage component displaying correct SVG with single illustration import.

Isolated Example

No response

Steps to Reproduce

1. 2. 3. ...

Log Output, Stack Trace or Screenshots

No response

Priority

Low

UI5 Web Components Version

1.21.2

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

nnaydenow commented 5 months ago

Hi @OliwiaGowor,

Could you please share with us which themes you are using because illustrations sometimes have different appearance depending on the theme?

Update: Ignore my previous comment. It's a strange behaviour because AllIllustrations import basically import the same file. Need to revise where the difference come from.

nnaydenow commented 5 months ago

Hello team

Seems like a side effect that comes from #7195. With the import §import "@ui5/webcomponents-fiori/dist/illustrations/tnt/NoApplications.js"` we only load and register v4 version of the illustration. This leads to wrong illustration that is displayed. Could you please check it?

ilhan007 commented 5 months ago

fyi @SAP/ui5-webcomponents-topic-p